Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Lazyload Katex Package #15398

Merged
merged 6 commits into from
Oct 16, 2019
Merged

[IMPROVE] Lazyload Katex Package #15398

merged 6 commits into from
Oct 16, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 17, 2019 •
edited by MartinSchoeler
Loading

No description provided.

@tassoevan tassoevan self-requested a review September 18, 2019 03:28
@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 16, 2019 18:39
@MartinSchoeler
Copy link
Contributor

@ggazzo I've tested this and these are the results:

Before:

Before 1

before 2

After:

After 1

after 2

@MartinSchoeler MartinSchoeler changed the title lazyload katex [IMPROVE] Lazyload Katex Package Oct 16, 2019
@ggazzo ggazzo merged commit 40eb927 into develop Oct 16, 2019
@ggazzo ggazzo deleted the lazy-katex branch October 16, 2019 19:29
@ggazzo ggazzo added this to the 2.2.0 milestone Oct 16, 2019
@ggazzo ggazzo added the ui/ux label Oct 16, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 4 alerts when merging 5a74816 into a6080f7 - view on LGTM.com

new alerts:

  • 4 for Property access on null or undefined

@MartinSchoeler MartinSchoeler mentioned this pull request Oct 16, 2019
Merged
@rodrigok rodrigok mentioned this pull request Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler Awaiting requested review from MartinSchoeler

@tassoevan tassoevan Awaiting requested review from tassoevan

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @MartinSchoeler